Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StubClock should probably be FakeClock #73

Closed
GoogleCodeExporter opened this issue Mar 15, 2015 · 5 comments
Closed

StubClock should probably be FakeClock #73

GoogleCodeExporter opened this issue Mar 15, 2015 · 5 comments
Labels
bug
Milestone

Comments

@GoogleCodeExporter
Copy link

@GoogleCodeExporter GoogleCodeExporter commented Mar 15, 2015

See e.g. http://martinfowler.com/articles/mocksArentStubs.html.  A "stub" is 
normally a pre-programmed implementation that contains no logic or expectations 
(q.v. EasyMock's asStubReturn()), while a "fake" is a better name for something 
that uses a non-production implementation for tests.

As it stands, I suppose that you could argue that StubClock is a stub, in that 
we currently only program it with the current time, but if we were to add any 
additional logic (e.g. as in issue 72), it's no longer an appropriate name.

Original issue reported on code.google.com by malcolm.rowe on 21 Apr 2012 at 9:36

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Mar 15, 2015

Blocking if we do it at all.

Original comment by malcolm.rowe on 23 Apr 2012 at 9:50

  • Added labels: V1-Blocker
@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Mar 15, 2015

Done in change d8f9a1bdb580.

Original comment by jonathan.skeet on 28 Jun 2012 at 9:19

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Mar 15, 2015

Original comment by jonathan.skeet on 28 Jun 2012 at 9:30

  • Changed state: Fixed
@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Mar 15, 2015

Original comment by malcolm.rowe on 30 Jul 2012 at 7:26

  • Added labels: Milestone-1.0
  • Removed labels: V1-Blocker
@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Mar 15, 2015

Original comment by malcolm.rowe on 10 Nov 2012 at 10:20

  • Added labels: Milestone-1.0.0
  • Removed labels: Milestone-1.0
@malcolmr malcolmr added the bug label Mar 15, 2015
@malcolmr malcolmr modified the milestone: 1.0.0 Mar 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants