Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IsoDayOfWeekExtensions.ToIsoDayOfWeek naming error #776

Closed
jskeet opened this issue Apr 12, 2017 · 3 comments
Closed

IsoDayOfWeekExtensions.ToIsoDayOfWeek naming error #776

jskeet opened this issue Apr 12, 2017 · 3 comments
Milestone

Comments

@jskeet
Copy link
Member

@jskeet jskeet commented Apr 12, 2017

It should obviously be ToDayOfWeek.

jskeet added a commit to jskeet/nodatime that referenced this issue Apr 12, 2017
We have to live with this until 3.0 now, of course... but at least
we can make the badly-named method obsolete.

Fixes nodatime#776.
@jskeet jskeet closed this in #777 Apr 12, 2017
jskeet added a commit that referenced this issue Apr 12, 2017
We have to live with this until 3.0 now, of course... but at least
we can make the badly-named method obsolete.

Fixes #776.
jskeet added a commit to jskeet/nodatime that referenced this issue Apr 12, 2017
Avoids nodatime#776 repeating.
(There may be other similar tests we could add...)
jskeet added a commit that referenced this issue Apr 13, 2017
Avoids #776 repeating.
(There may be other similar tests we could add...)
@cypressious
Copy link

@cypressious cypressious commented May 10, 2017

This means, a ToIsoDayOfWeek, that actually does what the name says, can't be added, right?

@jskeet
Copy link
Member Author

@jskeet jskeet commented May 10, 2017

No, that method already exists: http://nodatime.org/2.0.x/api/NodaTime.Extensions.DayOfWeekExtensions.html#NodaTime_Extensions_DayOfWeekExtensions_ToIsoDayOfWeek_System_DayOfWeek_

It's fine for both to exist because they have different parameter types.

@cypressious
Copy link

@cypressious cypressious commented May 10, 2017

I see, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants