LocalDate constructor validation not working

[jkonecki]

I've noticed a bug in NodaTime 2.0 LocalDate constructor - parameter validation doesn't seem to be working. It was working as expected in version 1.3.

Example:

var date = new LocalDate(2001, 1, -1);

Expected result:
An ArgumentOutOfRangeException should be thrown as described in documentation:

<exception cref="ArgumentOutOfRangeException">The parameters do not form a valid date.</exception>

Actual result:

A LocalDate instance is created and can be used:

            var date = new LocalDate(2001, 1, -1);
            var year = date.Year; // value: 0
            var month = date.Month; // value: 32
            var day = date.Day;  // value: 63

An ArgumentOutOfRangeException is thrown from ToString() method.

[jskeet]

Eek, thank you. Very surprising! (Surprises me that we don't have tests, either. That must change...) Will fix for 2.0.1.

[jskeet]

Ah, found it. We validate that the day-of-month isn't too high - but not that it's not < 1!