Can create LocalTime with 60 or 61 seconds #807

Closed
DmitryMak opened this Issue May 2, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@DmitryMak

I expect this to throw ArgumentOutOfRangeException, but it doesn't:

new LocalTime(13, 58, 61);

Instead it creates instance that represents 13:59:01

NodaTime (2.0.0)

@jskeet

This comment has been minimized.

Show comment
Hide comment
@jskeet

jskeet May 2, 2017

Member

Ooh, that's definitely a new one. Will investigate.

Member

jskeet commented May 2, 2017

Ooh, that's definitely a new one. Will investigate.

@jskeet

This comment has been minimized.

Show comment
Hide comment
@jskeet

jskeet May 2, 2017

Member

Found the bug; writing tests for the 5 identical cases.

Member

jskeet commented May 2, 2017

Found the bug; writing tests for the 5 identical cases.

jskeet added a commit to jskeet/nodatime that referenced this issue May 2, 2017

@jskeet jskeet closed this in #808 May 2, 2017

jskeet added a commit that referenced this issue May 2, 2017

@jskeet jskeet referenced this issue May 3, 2017

Closed

Consider 2.0.1 release #774

0 of 3 tasks complete

@malcolmr malcolmr added the bug label May 3, 2017

@malcolmr malcolmr added this to the 2.0.1 milestone May 3, 2017

jskeet added a commit to jskeet/nodatime that referenced this issue May 3, 2017

jskeet added a commit that referenced this issue May 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment