Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can create LocalTime with 60 or 61 seconds #807

Closed
DmitryMak opened this issue May 2, 2017 · 2 comments
Closed

Can create LocalTime with 60 or 61 seconds #807

DmitryMak opened this issue May 2, 2017 · 2 comments
Labels
Milestone

Comments

@DmitryMak
Copy link

@DmitryMak DmitryMak commented May 2, 2017

I expect this to throw ArgumentOutOfRangeException, but it doesn't:

new LocalTime(13, 58, 61);

Instead it creates instance that represents 13:59:01

NodaTime (2.0.0)

@jskeet
Copy link
Member

@jskeet jskeet commented May 2, 2017

Ooh, that's definitely a new one. Will investigate.

@jskeet
Copy link
Member

@jskeet jskeet commented May 2, 2017

Found the bug; writing tests for the 5 identical cases.

jskeet added a commit to jskeet/nodatime that referenced this issue May 2, 2017
@jskeet jskeet closed this in #808 May 2, 2017
jskeet added a commit that referenced this issue May 2, 2017
Fixes #807.
@jskeet jskeet mentioned this issue May 3, 2017
0 of 3 tasks complete
@malcolmr malcolmr added the bug label May 3, 2017
@malcolmr malcolmr added this to the 2.0.1 milestone May 3, 2017
jskeet added a commit to jskeet/nodatime that referenced this issue May 3, 2017
jskeet added a commit that referenced this issue May 4, 2017
Fixes #807.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants