Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a test double for IDateTimeZoneProvider #83

Closed
GoogleCodeExporter opened this issue Mar 15, 2015 · 3 comments
Closed

Provide a test double for IDateTimeZoneProvider #83

GoogleCodeExporter opened this issue Mar 15, 2015 · 3 comments
Labels
Milestone

Comments

@GoogleCodeExporter
Copy link

@GoogleCodeExporter GoogleCodeExporter commented Mar 15, 2015

We provide a fake clock and a single transition time zone, but we
have nothing for IDateTimeZoneProvider. We should consider implementing
a fake IDateTimeZoneSource, and suggesting developers build DateTimeZoneCache 
instances from that.

Exact requirements TBD, based on user feedback.

Original issue reported on code.google.com by jonathan.skeet on 12 Jul 2012 at 1:17

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Mar 15, 2015

Original comment by malcolm.rowe on 13 Jul 2012 at 8:33

  • Added labels: Type-Enhancement
@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Mar 15, 2015

Original comment by malcolm.rowe on 30 Jul 2012 at 7:47

  • Added labels: Milestone-1.1-consider
  • Removed labels: V1-OutOfScope
@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Mar 15, 2015

Fixed by revision 74731b1d9808, though Jon is going to rename the class to 
FakeDateTimeSource separately.

Original comment by malcolm.rowe on 25 Jan 2013 at 8:44

  • Changed state: Fixed
  • Added labels: Milestone-1.1.0
  • Removed labels: Milestone-1.1-consider
@malcolmr malcolmr modified the milestone: 1.1.0 Mar 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.