New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PeriodBuilder shouldn't support equality or hashability natively #91

Closed
GoogleCodeExporter opened this Issue Mar 15, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@GoogleCodeExporter

GoogleCodeExporter commented Mar 15, 2015

PeriodBuilder supports value equality and hashability. Why?

a. It's not particularly usual for builders to support these operations, since 
they're almost never compared with other instances.  (Also insert standard 
comment about hashability for mutable values.)
b. PeriodBuilder actually supports a _different_ notion of equality from 
Period, because absent values _are_ differentiated from zero values (while 
they're not in Period).

Original issue reported on code.google.com by malcolm.rowe on 26 Jul 2012 at 2:31

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 15, 2015

Hmm. I *suspect* it's for the sake of testing, which isn't a terribly good 
argument really. That code could easily be within the test class. I agree it's 
pretty odd.

Original comment by jonathan.skeet on 26 Jul 2012 at 6:18

GoogleCodeExporter commented Mar 15, 2015

Hmm. I *suspect* it's for the sake of testing, which isn't a terribly good 
argument really. That code could easily be within the test class. I agree it's 
pretty odd.

Original comment by jonathan.skeet on 26 Jul 2012 at 6:18

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 15, 2015

Per discussion: we'll remove these, and fix up the tests.

Though see also issue 90, which is going to simplify equality anyway.

Original comment by malcolm.rowe on 26 Jul 2012 at 12:00

  • Changed title: PeriodBuilder shouldn't support equality or hashability natively

GoogleCodeExporter commented Mar 15, 2015

Per discussion: we'll remove these, and fix up the tests.

Though see also issue 90, which is going to simplify equality anyway.

Original comment by malcolm.rowe on 26 Jul 2012 at 12:00

  • Changed title: PeriodBuilder shouldn't support equality or hashability natively
@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 15, 2015

Fixed in change 1e33eea558f6.

Original comment by malcolm.rowe on 26 Jul 2012 at 9:58

  • Changed state: Fixed

GoogleCodeExporter commented Mar 15, 2015

Fixed in change 1e33eea558f6.

Original comment by malcolm.rowe on 26 Jul 2012 at 9:58

  • Changed state: Fixed
@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 15, 2015

Original comment by malcolm.rowe on 30 Jul 2012 at 7:26

  • Added labels: Milestone-1.0
  • Removed labels: V1-Blocker

GoogleCodeExporter commented Mar 15, 2015

Original comment by malcolm.rowe on 30 Jul 2012 at 7:26

  • Added labels: Milestone-1.0
  • Removed labels: V1-Blocker
@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 15, 2015

Original comment by malcolm.rowe on 10 Nov 2012 at 10:20

  • Added labels: Milestone-1.0.0
  • Removed labels: Milestone-1.0

GoogleCodeExporter commented Mar 15, 2015

Original comment by malcolm.rowe on 10 Nov 2012 at 10:20

  • Added labels: Milestone-1.0.0
  • Removed labels: Milestone-1.0

@malcolmr malcolmr added the bug label Mar 15, 2015

@malcolmr malcolmr modified the milestone: 1.0.0 Mar 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment