Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LocalInstant.SafeMinus gives incorrect result around the start/end of time #957

Closed
jskeet opened this issue Aug 22, 2017 · 0 comments
Closed
Assignees
Milestone

Comments

@jskeet
Copy link
Member

@jskeet jskeet commented Aug 22, 2017

The call to PlusSmallNanoseconds should be MinusSmallNanoseconds.

Discovered while adding test coverage. The fix is trivial - we should probably backport to the 2.2 branch, but it's sufficiently corner-casey to mean it's probably not worth doing a 2.2.1 build just for that.

@jskeet jskeet self-assigned this Aug 22, 2017
jskeet added a commit to jskeet/nodatime that referenced this issue Aug 22, 2017
@jskeet jskeet closed this in #958 Aug 22, 2017
jskeet added a commit that referenced this issue Aug 22, 2017
jskeet added a commit to jskeet/nodatime that referenced this issue Aug 22, 2017
jskeet added a commit that referenced this issue Aug 22, 2017
@jskeet jskeet mentioned this issue Aug 22, 2017
4 of 4 tasks complete
@malcolmr malcolmr added this to the 2.2.1 milestone Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.