Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Crash on ECONNRESET #138

Closed
Ecco opened this Issue Nov 19, 2013 · 1 comment

Comments

Projects
None yet
2 participants

Ecco commented Nov 19, 2013

If the socket is reset, then node-apn assumes the notification was in flight, but it is not always the case. Namely, we're hitting this:

if(socket.busy) {
  // A notification was in flight. It should be buffered for resending.
  this.bufferNotification(socket.cachedNotifications[socket.cachedNotifications.length - 1]);
}

when cachedNotification is actually empty. It therefore calls bufferNotification with an undefined notification, which crashes node-apn.

Collaborator

argon commented Nov 19, 2013

Are you running in legacy / non-enhanced mode? I am confused how this could be hit before anything has ended up in the cache.

I agree it's a problem but want to understand whether there's an underlying problem here.

@argon argon closed this Jan 13, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment