Adding flag to truncate string at word boundaries #120

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

goelvivek commented Sep 24, 2013

Adding one optional flag to truncate string at word boundaries.

Collaborator

argon commented Sep 24, 2013

This likely won't work correctly for multibyte characters. The length is in bytes not characters. The string needs to be truncated to maximum byte length first, then if necessary removing more to reach the word boundary.

Also, as the truncation happens internally within the notification there should be a flag on the notification to specify whether truncation should happen at the word boundary within the #trim() method.

Contributor

goelvivek commented Sep 30, 2013

OK. Will recreate the request.

@goelvivek goelvivek closed this Sep 30, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment