Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default user-agent string still version 1.0? #503

Closed
jkantr opened this issue Aug 15, 2018 · 2 comments
Closed

Default user-agent string still version 1.0? #503

jkantr opened this issue Aug 15, 2018 · 2 comments

Comments

@jkantr
Copy link
Collaborator

jkantr commented Aug 15, 2018

https://github.com/bitinn/node-fetch/blob/1d4ab5a0de0df991f92f1f30efd5f4815bbcdb71/src/request.js#L186

Should node-fetch/1.0 be changed to node-fetch/2.0? Or has that ship sailed?

@TimothyGu TimothyGu added this to the Version 3.0.0 milestone Aug 16, 2018
@TimothyGu
Copy link
Collaborator

TimothyGu commented Aug 16, 2018

Eh, I'd say it has sailed. I'd personally even be fine with just keeping it at 1.0 forever.

@bitinn
Copy link
Collaborator

bitinn commented Aug 16, 2018

It is simply an indicator to servers anyway, let's keep it at 1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants