Referrer and Referrer Policy #1057
Conversation
|
@tinovyatkin You are quite right. I've updated the TS types |
|
Hi, is it just lack of reviews that stops this from getting merged? |
|
@jimmywarting thanks! @bitinn looks like this only awaits your review now, would be really nice to merge this. As a side note: in Chrome dev tools, when one selects "copy as Node.js fetch", the request is copied with |
|
@jimmywarting I had to resolve some merge conflicts and fix some errors, but this is ready to merge now. To follow good form, would you mind giving it one more once-over and merge if it looks good? |
|
will take a 2nd look at it |
|
looks good to me |
|
Thanks for the amazing work! |
|
Great! In which version can we expect the update? |
|
Should be version |
|
Don't think we have any valuable new features to push out, it's mostly docs, deprecations and other minor things. it will come when it comes |
| expect(() => { | ||
| const req = new Request('http://example.com', {referrer: 'foobar'}); | ||
| expect.fail(req); | ||
| }).to.throw(TypeError, 'Invalid URL: foobar'); |
There was a problem hiding this comment.
now when this is merged and i'm running test locally, this one fails
What is the purpose of this pull request?
What changes did you make? (provide an overview)
This adds support for the
referrerandreferrerPolicyoptions.Which issue (if any) does this pull request address?
#1036 #839
Is there anything you'd like reviewers to know?
Specifications are referenced in-line.