Don't change relative location header on manual redirect #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekwiz
force-pushed
the
fix/relative-manual-redirect
branch
from
8232b42
to
09df486
Compare
tekwiz
force-pushed
the
fix/relative-manual-redirect
branch
from
52f864b
to
53ead47
Compare
LinusU
approved these changes
Nov 4, 2021
|
@tekwiz I think that the linting issue has been fixed on the latest master, could you rebase please? |
tekwiz
force-pushed
the
fix/relative-manual-redirect
branch
from
53ead47
to
10a934a
Compare
This was referenced Jan 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
What changes did you make? (provide an overview)
This removes the code that changes the location header to an absolute URL in the case of a manual redirect request. While doing this is helpful in most cases, it is too destructive in cases where the original, actual location header is needed. See the situation described in #1086.
This change also documents the variation from the spec
This change reduces the total lines of code, thus reducing the overall test percentage for test coverage. To keep that check passing, I added some appropriate c8 ignores to unrelated code (see 52f864b)
Which issue (if any) does this pull request address?
Fixes #1086
Is there anything you'd like reviewers to know?
No