Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing for Response.redirect(url, status) #1169

Merged
merged 1 commit into from Nov 5, 2021
Merged

Add typing for Response.redirect(url, status) #1169

merged 1 commit into from Nov 5, 2021

Conversation

c-w
Copy link
Contributor

@c-w c-w commented May 25, 2021

What is the purpose of this pull request?

  • Documentation update

What changes did you make?

In #1078, the static Response.redirect(url, status) was added to the project but without typings which can be confusing for users. This pull request provides the typings for the method.

@tkrotoff
Copy link
Contributor

@tkrotoff tkrotoff commented Aug 4, 2021

btw #1078 did not add Response.redirect() ;-)

LinusU
LinusU approved these changes Aug 5, 2021
Copy link
Member

@LinusU LinusU left a comment

👍

LinusU
LinusU approved these changes Aug 6, 2021
@jimmywarting
Copy link
Collaborator

@jimmywarting jimmywarting commented Sep 4, 2021

is this still relevant?

@c-w
Copy link
Contributor Author

@c-w c-w commented Sep 6, 2021

@jimmywarting Yes I believe so. The original reasons for me opening this PR are still valid (e.g. hindering discovery of the API via auto-complete due to lack of type annotations). Do you have any concerns about merging this?

@LinusU LinusU requested a review from jimmywarting Nov 5, 2021
@jimmywarting jimmywarting merged commit ff7e950 into node-fetch:main Nov 5, 2021
1 check passed
@c-w c-w deleted the response-redirect-type-annotation branch Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants