Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(package.json): Corrected main file path in package.json #1274

merged 9 commits into from Sep 6, 2021


Copy link

@jimmywarting jimmywarting commented Sep 4, 2021


Fixes a problem when some tries to read the main file.
It was a problem due to lack of file extension


  • Added file extension in package.json "main":
  • I updated patch version in package.json
  • I pinned codecov + teeny-request (it had breaking change)
  • also changed the "external" function ( 2b0610d ) - rollup had some breaking changes also


This is for v2

  • I updated changelog

Copy link

@codecov codecov bot commented Sep 4, 2021

Codecov Report

Merging #1274 (d9a4a07) into 2.x (b5e2e41) will decrease coverage by 0.34%.
The diff coverage is n/a.

Current head d9a4a07 differs from pull request most recent head dd73fe7. Consider uploading reports for the commit dd73fe7 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##               2.x    #1274      +/-   ##
- Coverage   100.00%   99.65%   -0.35%     
  Files            7        7              
  Lines          573      573              
  Branches       183      183              
- Hits           573      571       -2     
- Misses           0        1       +1     
- Partials         0        1       +1     
Impacted Files Coverage Δ
src/request.js 98.03% <0.00%> (-1.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5e2e41...dd73fe7. Read the comment docs.

Copy link
Collaborator Author

@jimmywarting jimmywarting commented Sep 5, 2021

Seems like teeny-request has a breaking change for an older node version where it uses spread ... would it help to install it as a dep, pin it so codecov uses it instead?

@jimmywarting jimmywarting self-assigned this Sep 5, 2021
Copy link
Collaborator Author

@jimmywarting jimmywarting commented Sep 5, 2021

Ironically codecov uses teeny-request
and teeny-request just wraps node-fetch v2.6.1

So we use our own fetch api to test our own api...

but at codecov i found out that:

On February 1, 2022 this uploader will be completely deprecated and will no longer be able to upload coverage to Codecov.

Copy link
Collaborator Author

@jimmywarting jimmywarting commented Sep 5, 2021

... do rollup have some breaking change also?

src/index.js → lib/index.js, lib/, lib/index.mjs...
[!] TypeError: Cannot read property 'src' of undefined
TypeError: Cannot read property 'src' of undefined
    at external (./node-fetch/rollup.config.js:47:52)

Copy link
Collaborator Author

@jimmywarting jimmywarting commented Sep 5, 2021

the external function did something that didn't work. 2b0610d
don't remember what we use this for...
either way... we don't have any dependencies in package.json so i just removed that part and it started working again. Outdated Show resolved Hide resolved
gr2m approved these changes Sep 5, 2021
LinusU approved these changes Sep 6, 2021
Copy link

@LinusU LinusU left a comment

Nice 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants