Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix octocat image link #1281

Merged
merged 2 commits into from Sep 9, 2021
Merged

Fix octocat image link #1281

merged 2 commits into from Sep 9, 2021

Conversation

lakuapik
Copy link
Contributor

@lakuapik lakuapik commented Sep 9, 2021

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • New feature
  • Other, please explain:

What changes did you make? (provide an overview)

When i try to copy and paste the example code from https://github.com/node-fetch/node-fetch#streams, i got error and turns out the image link for https://assets-cdn.github.com/images/modules/logos_page/Octocat.png is dead. This PR just replace the image with new one, same as buffer example.

Which issue (if any) does this pull request address?

Is there anything you'd like reviewers to know?

LinusU
LinusU approved these changes Sep 9, 2021
Copy link
Member

@LinusU LinusU left a comment

👍

@Richienb Richienb changed the title Replace octocat image link Fix octocat image link Sep 9, 2021
@Richienb Richienb merged commit 9cd2e43 into node-fetch:main Sep 9, 2021
@lakuapik lakuapik deleted the patch-1 branch Sep 9, 2021
@renovate renovate bot mentioned this pull request Feb 4, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants