Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix v2.6.3 that did not send query params #1301

Merged
merged 1 commit into from Sep 21, 2021
Merged

fix v2.6.3 that did not send query params #1301

merged 1 commit into from Sep 21, 2021

Conversation

jimmywarting
Copy link
Collaborator

@jimmywarting jimmywarting commented Sep 21, 2021

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • New feature
  • Other, please explain:

closes #1300

@jimmywarting
Copy link
Collaborator Author

@jimmywarting jimmywarting commented Sep 21, 2021

This have already been released to npm
had to get it out quickly, it was breaking a few things.

So no other choice then to merge

LinusU
LinusU approved these changes Sep 21, 2021
Copy link
Member

@LinusU LinusU left a comment

Thank you for the quick follow up on this! ❤️

@jimmywarting jimmywarting merged commit 18193c5 into 2.x Sep 21, 2021
@jimmywarting jimmywarting deleted the fix-v2.6.3 branch Sep 21, 2021
expect(json.url).to.equal('/inspect?month=2021-09')
})
})

Copy link
Collaborator

@gr2m gr2m Sep 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for putting in a test to avoid future regressions 💐

This explains the mystery of octokit/rest.js#114 and semantic-release/github#415

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants