2.x: Specify encoding as an optional peer dependency in package.json #1310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
What is the purpose of this pull request?
What changes did you make? (provide an overview)
I installed node-fetch 2.x on my project with Yarn 2 (aka Yarn berry). When I call
require('node-fetch')
, I get this warning message:It seems that
encoding
package is optional and only used inbody.textConverted()
method (discussed in #412).So I added the following to
package.json
of node-fetch:Which issue (if any) does this pull request address?
Is there anything you'd like reviewers to know?