Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Headers): Add default Host request header to README.md file #1316

Merged
merged 1 commit into from Sep 27, 2021

Conversation

robertoaceves
Copy link
Contributor

@robertoaceves robertoaceves commented Sep 27, 2021

Mention the Host header in the default request headers table.

According to the standard RFC 7230 Hypertext Transfer Protocol (HTTP/1.1): Message Syntax and Routing

"A client MUST send a Host header field in all HTTP/1.1 request messages."

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • New feature
  • Other, please explain:

What changes did you make? (provide an overview)
Add information to the documentation.

Mention the Host header in the default request headers table.

According to the standard [RFC 7230 Hypertext Transfer Protocol (HTTP/1.1): Message Syntax and Routing |https://httpwg.org/specs/rfc7230.html#header.host]
    "A client MUST send a Host header field in all HTTP/1.1 request messages."
Copy link
Collaborator

@jimmywarting jimmywarting left a comment

For some reason you kept it alphabetical :P

Anyhow. LGTM

LinusU
LinusU approved these changes Sep 27, 2021
Copy link
Member

@LinusU LinusU left a comment

Neat 👍

@jimmywarting jimmywarting changed the title Add default Host request header to README.md file docs(Headers): Add default Host request header to README.md file Sep 27, 2021
@jimmywarting jimmywarting merged commit 3b99832 into node-fetch:main Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants