fix(Request): Fix logical operator priority to disallow GET/HEAD with non-empty body #1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmywarting
changed the title
jimmywarting
changed the title
LinusU
approved these changes
Nov 10, 2021
jimmywarting
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Purpose
There was a regression introduced in a conditional which checks for a
bodyoverride inRequest, where brackets were at the wrong place. Because of this, in certain cases, one could create a GET/HEADRequestinstance with a non-empty body, which should normally result in anTypeErrorthrown.Changes
This PR fixes the issue, and adds a test for this particular case.
Additional information