Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(http.request): Cast URL to string before sending it to NodeJS core #1378

Merged
merged 2 commits into from Nov 12, 2021

Conversation

jimmywarting
Copy link
Collaborator

@jimmywarting jimmywarting commented Nov 11, 2021

Purpose

In #1268 we started to just forward the URL to node's Request method instead of sending everything as an option, This broke something as we where not passing it as a string.

Changes

I casted the URL into a string before handing the url to NodeJS http.request method
send(parsedURL.toString(), options);


@jimmywarting jimmywarting requested review from LinusU and gr2m Nov 11, 2021
gr2m
gr2m approved these changes Nov 11, 2021
Copy link
Collaborator

@gr2m gr2m left a comment

Changes look good to me 👍🏼

LinusU
LinusU approved these changes Nov 12, 2021
Copy link
Member

@LinusU LinusU left a comment

Neat 👍

@jimmywarting jimmywarting merged commit 0284826 into main Nov 12, 2021
8 checks passed
@jimmywarting jimmywarting deleted the feature/fix-url-instances branch Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants