fix(Redirect): Better handle wrong redirect header in a response

[tasinet]

Purpose

Fixes crash when a Location header point to an invalid URL

Changes

Just wrapping new URL() in a try/catch and returning a sensible (?) error message

Additional information

Test included

---

• I updated ./docs/CHANGELOG.md with a link to this PR or Issue
• I added unit test(s)

---

• Fixes #1386

[LinusU]

LGTM 👍

[jimmywarting]

Just thought of something... and i tested this in chrome...

if you have redirect: 'manual' then it shouldn't follow the redirect header and try to fetch it... then you may think that it should not throw any error for having invalid headers but it dose...

fetch(/redirect/301/invalid', { redirect: 'manual' })

so i tested it in firefox, and safari also

// FF OK
fetch('/redirect/301/invalid', { redirect: 'manual' }).then(console.log, console.error)
// Safari OK
fetch('/redirect/301/invalid', { redirect: 'manual' }).then(console.log, console.error)
// Chrome Throws
fetch('/redirect/301/invalid', { redirect: 'manual' }).then(console.log, console.error)

We should have a test case for both.
would you mind

• Adding unit test for when redirect is set to manual and dose not throw
• Resolve the conflicts

Should also report this to Chrome / WPT

[jimmywarting]

Reported it to chrome: https://bugs.chromium.org/p/chromium/issues/detail?id=1271920

[jimmywarting]

need a redirect=manual test that don't throw

[tasinet]

Made some changes

• linting catch(_error) { -> catch {
• Does not throw when options.redirect == manual
• Added test for above
• Resolved CHANGELOG conflict

[tasinet]

Do you need anything else from my end here?

[LinusU]

LGTM