Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme for TS @types/node-fetch #1405

Merged

Conversation

adamellsworth
Copy link
Contributor

@adamellsworth adamellsworth commented Dec 5, 2021

Purpose

Closes #1396

Changes

Updates Readme such that the @types/node-fetch refs the last known version with valid types (@types/node-fetch@2.x); targets users who cannot upgrade to node-fetch@3.x

Additional information

n/a


  • I updated readme

Note to reviewers of this PR:
because of the minuscule nature of this change I have not updated the Changelog – I feel such an addition would add a bit of unnecessary "noise" to the real additions to the codebase.
also, ty for writing such an amazing lib <3

@adamellsworth adamellsworth changed the title update readme for TS @type/node-fetch update readme for TS @types/node-fetch Dec 5, 2021
LinusU
LinusU approved these changes Dec 6, 2021
Copy link
Member

@LinusU LinusU left a comment

👍

@jimmywarting jimmywarting merged commit 7ba5bc9 into node-fetch:main Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants