Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Warn when using data #1421

Merged
merged 7 commits into from Jan 8, 2022
Merged

core: Warn when using data #1421

merged 7 commits into from Jan 8, 2022

Conversation

jimmywarting
Copy link
Collaborator

@jimmywarting jimmywarting commented Dec 19, 2021

Purpose

superseeds #1333

Added a one-time warning for when .data is used in any way, as a way to help porting from other libraries for requests (such as axios).

  • I added unit test(s)

@jimmywarting jimmywarting mentioned this pull request Dec 19, 2021
4 tasks
gr2m
gr2m approved these changes Jan 7, 2022
@jimmywarting jimmywarting merged commit 4ae3538 into main Jan 8, 2022
8 checks passed
@jimmywarting jimmywarting deleted the TheGLander-add-req-res-data-warn branch Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants