Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Modernize and convert some test in main.js to async/await #1456

Merged
merged 6 commits into from Jan 17, 2022

Conversation

jimmywarting
Copy link
Collaborator

@jimmywarting jimmywarting commented Jan 16, 2022

Purpose

to tidy up and get rid of some indentation hell

Changes

No other test file than main.js file was changed.
the test are still the same...

@jimmywarting jimmywarting changed the title test: Modernize and convert some to async/await test: Modernize and convert some test in main.js to async/await Jan 16, 2022
@jimmywarting jimmywarting requested a review from LinusU Jan 16, 2022
test/main.js Outdated Show resolved Hide resolved
test/main.js Outdated Show resolved Hide resolved
LinusU
LinusU approved these changes Jan 17, 2022
Copy link
Member

@LinusU LinusU left a comment

Looks good, just a few nits 👍

jimmywarting and others added 2 commits Jan 17, 2022
Co-authored-by: Linus Unnebäck <linus@folkdatorn.se>
test/main.js Outdated Show resolved Hide resolved
LinusU
LinusU approved these changes Jan 17, 2022
Copy link
Member

@LinusU LinusU left a comment

Neat! 👍

@jimmywarting jimmywarting merged commit 015798e into node-fetch:main Jan 17, 2022
9 checks passed
@jimmywarting jimmywarting deleted the update-tests branch Jan 17, 2022
@github-actions
Copy link

github-actions bot commented Jan 20, 2022

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@node-fetch node-fetch deleted a comment from zelma83 Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants