Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Update major busboy version #1457

Merged
merged 2 commits into from Jan 17, 2022

Conversation

jimmywarting
Copy link
Collaborator

@jimmywarting jimmywarting commented Jan 16, 2022

Purpose

dependabot wasn't able to update busboy cuz it had breaking changes...

Changes

Only affect the test server...

Additional information

I was thinking maybe we don't really need the busboy...? we could just simply echo everything back and utilize node-fetch new body.formData() parsers.
and then do something like:

fetch('/multipart', { method: 'post', body: formData })
  .then(res => res.formData())
  .then(formData => {
    // expect responded formData to match the posted formData
  })

Dos removing the dependency on busboy...


  • Decide if we want to keep busboy as a dependency... if not:
    • use res.formData() to decode it.

@jimmywarting jimmywarting added this to the Version 3.x.x milestone Jan 16, 2022
@jimmywarting jimmywarting changed the title test: Update busboy test: Update major busboy version Jan 16, 2022
gr2m
gr2m approved these changes Jan 16, 2022
LinusU
LinusU approved these changes Jan 17, 2022
Copy link
Member

@LinusU LinusU left a comment

Neat 👍

@jimmywarting jimmywarting merged commit 1028f83 into node-fetch:main Jan 17, 2022
9 checks passed
@jimmywarting jimmywarting deleted the bump-busboy branch Jan 17, 2022
@github-actions
Copy link

github-actions bot commented Jan 20, 2022

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants