-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cancel request example import #1513
fix: cancel request example import #1513
Conversation
Hmm, wondering if not we should try to fix the real problem that is that we return a custom AbortError message, it should rather be a // Browser test:
ctrl = new AbortController()
ctrl.abort()
fetch('/', ctrl).catch(console.log)
// DOMException {
// name: AbortError,
// code: 20,
// message: "Failed to execute 'fetch' on 'Window': The user aborted a request."
// } We could optionally start to depend on node-domexception. it's already included by another sub dependency of ours (fetch-blob). |
Co-authored-by: Linus Unnebäck <linus@folkdatorn.se>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@jimmywarting I think that would be nice, but I still think that we should merge this one in the mean time 👍 |
Alright. maybe change it in next major release to avoid breakage? |
🎉 This PR is included in version 3.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
should maybe have done |
Fixes cancel request example import.