Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change error message thrown with redirect mode set to error #653

Merged
merged 1 commit into from Oct 10, 2019

Conversation

@ramitmittal
Copy link
Contributor

@ramitmittal ramitmittal commented Jun 18, 2019

The original error message does not provide enough information about what went wrong. It simply states a configuration setting.

The original error message does not provide enough information about what went wrong. It simply states a configuration setting.
@codecov-io
Copy link

@codecov-io codecov-io commented Jun 18, 2019

Codecov Report

Merging #653 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #653   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           7      7           
  Lines         587    569   -18     
  Branches      183    181    -2     
=====================================
- Hits          587    569   -18
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) ⬆️
src/headers.js 100% <0%> (ø) ⬆️
src/body.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95286f5...1ff5ff1. Read the comment docs.

Copy link
Collaborator

@gr2m gr2m left a comment

Nice, I like it 👍

@bitinn
Copy link
Collaborator

@bitinn bitinn commented Jun 22, 2019

I will try to merge this on next 2.x release, thx

@Richienb
Copy link
Member

@Richienb Richienb commented Oct 10, 2019

Due to input from @gr2m and @bitinn, It's time to merge this.

@Richienb Richienb merged commit 1e99050 into node-fetch:master Oct 10, 2019
3 checks passed
3 checks passed
codecov/patch 100% of diff hit (target 100%)
Details
codecov/project 100% (+0%) compared to 95286f5
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ramitmittal ramitmittal deleted the ramitmittal:patch-1 branch Oct 11, 2019
isaacs added a commit to npm/minipass-fetch that referenced this pull request Oct 18, 2019
The original error message does not provide enough information about
what went wrong. It simply states a configuration setting.

Via: node-fetch/node-fetch#653
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.