Change error message thrown with redirect mode set to error #653
Conversation
The original error message does not provide enough information about what went wrong. It simply states a configuration setting.
Codecov Report
@@ Coverage Diff @@
## master #653 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 7 7
Lines 587 569 -18
Branches 183 181 -2
=====================================
- Hits 587 569 -18
Continue to review full report at Codecov.
|
|
Nice, I like it |
|
I will try to merge this on next 2.x release, thx |
isaacs
added a commit
to npm/minipass-fetch
that referenced
this pull request
Oct 18, 2019
The original error message does not provide enough information about what went wrong. It simply states a configuration setting. Via: node-fetch/node-fetch#653
This was referenced Sep 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The original error message does not provide enough information about what went wrong. It simply states a configuration setting.