Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for global.fetch before binding it #674

Merged
merged 1 commit into from Sep 16, 2019

Conversation

@bbosiljcic
Copy link
Contributor

@bbosiljcic bbosiljcic commented Sep 16, 2019

We ran into some issues where this was executed in browsers that didn't support fetch (e.g. IE11)

@Richienb Richienb requested review from bitinn and xxczaki Sep 16, 2019
Copy link
Member

@Richienb Richienb left a comment

LGTM. We just need one more approving review from @bitinn or @xxczaki.

@bitinn
Copy link
Collaborator

@bitinn bitinn commented Sep 16, 2019

AFAIK we will be dropping browser export in v3 release, so this is a band-aid patch for v2 only, if there is going to be another release of v2.

The correct solution would be to use some of these suggested modules that export correctly given contexts.

https://github.com/bitinn/node-fetch#motivation

Otherwise LGTM

@Richienb Richienb merged commit 5535c2e into node-fetch:master Sep 16, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.