Skip to content

/ node-fetch

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix typos and grammatical errors in README.md #686

Merged
merged 1 commit into from Oct 21, 2019
Merged

docs: Fix typos and grammatical errors in README.md #686

merged 1 commit into from Oct 21, 2019

Conversation

@Sesamestrong
Copy link
Contributor

@Sesamestrong Sesamestrong commented Oct 20, 2019

No description provided.

@Sesamestrong
Fix typos and grammatical errors in README.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3051daf
@codecov-io
Copy link

@codecov-io codecov-io commented Oct 20, 2019 •
edited

Codecov Report

Merging #686 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #686   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           7      7           
  Lines         579    579           
  Branches      185    185           
=====================================
  Hits          579    579

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e99050...3051daf. Read the comment docs.
@xxczaki
xxczaki approved these changes Oct 20, 2019
View changes
Copy link
Member

@xxczaki xxczaki left a comment

LGTM, but since English is not my first language, I will wait for others to review this PR 😄
@Sesamestrong
Copy link
Contributor Author

@Sesamestrong Sesamestrong commented Oct 20, 2019

Sounds good!
@Richienb
Richienb approved these changes Oct 21, 2019
View changes
@Richienb Richienb changed the title Fix typos and grammatical errors in README.md docs: Fix typos and grammatical errors in README.md Oct 21, 2019
@Richienb Richienb merged commit 8c197f8 into node-fetch:master Oct 21, 2019
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing 1e99050...3051daf
Details
codecov/project 100% remains the same compared to 1e99050
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
This was referenced Sep 12, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xxczaki xxczaki

@Richienb Richienb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@Sesamestrong @codecov-io @xxczaki @Richienb
You can’t perform that action at this time.