node-fetch / node-fetch Public
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Body.body): Normalize Body.body
into a node:stream
#924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Body.body
into a stream
4 tasks
Body.body
into a streamBody.body
into a node:stream
gr2m
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Purpose
Normalize
Body.body
into a stream to be more in line with spec.and also to simplify other parts so we deal with less underlying types of bodies
Changes
Constructing a Response or Request with a string, blob or anything else gets converted into a
node:stream
nowPreviously, what you passed into the Response or Request as a body would in the end be the same thing in
Body.body
(new Response('abc').body === 'abc'
). This is wrong.Additional
Right now it's converted into a node:stream but i'm thinking it can be converted to a whatwg:stream in v4
it would be suppressing to me if someone rely on Response.body being whatever was passed to the Response constructor, not necessarily a stream. so perhaps this can slip in as a non major change?
I also lowercased the
nodefetchformdataboundary
cuz one issue is that Blob's type is casted to lowercase also