Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix get wrong http request body length #265

Merged
merged 3 commits into from Mar 14, 2017

Conversation

peaksnail
Copy link
Contributor

In fact, the length of string in node may not be equal the actual string length, and the server will get wrong sql,so use Buffer to get the string length.

example:

var text='你好' // this string is chinese
console.log(text.length) will be 2,but actual it's 6.

@connor4312
Copy link
Member

Good catch! Do you mind adding a quick test case for this?

@connor4312 connor4312 merged commit 97bab3b into node-influx:master Mar 14, 2017
@brokentone
Copy link

I'm just learning InfluxDB and got caught by this bug which wasted about 6 of my hours debugging in the last 2 days. Looks like it was fix 2 years ago, but never released. It was kind of a lark that I even found it... but that's a different story.

Any chance we could get a new release? @bencevans @connor4312

@bencevans
Copy link
Member

Sorry to hear that @brokentone we'll get something up shortly.

@brokentone
Copy link

@bencevans ehh, it's free software, I can't be too upset. Appreciate the quick response and looking forward to the release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants