Chrome 14: new websocket protocol #56

Closed
dannycoates opened this Issue Aug 5, 2011 · 6 comments

Comments

Projects
None yet
4 participants
Owner

dannycoates commented Aug 5, 2011

the new websocket spec doesn't work with current websocket library

akumpf commented Aug 15, 2011

Seems to be in socket.io or websocket-server. Hopefully fixes to those packages will resolve things for node-inspector as they are rolled in.

Would this websocket change be causing an error like this:

buffer.js:374
  if (end > this.length) throw new Error('oob');
                               ^
Error: oob
    at Buffer.slice (buffer.js:374:32)
    at Object.parse (/Users/bent/Work/Source/fiveoclocksong/node_modules/faye/faye-node.js:1422:27)
    at Socket.<anonymous> (/Users/bent/Work/Source/fiveoclocksong/node_modules/faye/faye-node.js:1174:20)
    at Socket.emit (events.js:64:17)
    at Socket._onReadable (net.js:678:14)
    at IOWatcher.onReadable [as callback] (net.js:177:10)
Owner

dannycoates commented Aug 24, 2011

This looks like a problem with your project, not the debugger. Is using the debugger causing the exception? It looks like faye is trying to slice with an out of bound (oob) index. I don't know enough about faye to help if its not the debugger's fault.

Maybe stick a breakpoint on line 1422 of faye-node.js to see what's going on.

I tried sticking a breakpoint on line 1422 but the local variables weren't showing up. I think this is a bug in node-inspector.

Just a note, this same exact code works fine when browsing with Chrome 12, but not in Chrome 15. This is what led me to believe it was related to the spec changes. I'll see if I can't dig any deeper (or just stick some log messages in).

EDIT: To reproduce the error, all I did was throw a bunch of messages at the server and it eventually choked. It wasn't necessarily consistent on when it choked, but it did every time when browsing with Chrome 15.

3rd-Eden commented Sep 2, 2011

Socket.IO supports the latest chrome web socket specification (which is the reason why it's broken atm) btw.

Owner

dannycoates commented Sep 2, 2011

cool, thanks. I'll look at switching to socket.io this weekend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment