Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Remove reliance on HTTP for socket io connection to server #140

Merged
merged 1 commit into from

2 participants

@mattheworiordan

No description provided.

@bajtos
Owner

Good point, I suspect // would do, however I am not familiar with the implementation details of that io object. I do know my solution works though ;)

Fair enough. Please rebase your change on the latest master so that I can merge the pull request.

@mattheworiordan

Ok, this pull request has now been rebased.

@bajtos bajtos merged commit 58fbdbe into from
@bajtos
Owner

Landed, thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  front-end-node/Overrides.js
View
2  front-end-node/Overrides.js
@@ -1,6 +1,6 @@
// Wire up websocket to talk to backend
WebInspector.loaded = function() {
- WebInspector.socket = io.connect('http://' + window.location.host + '/');
+ WebInspector.socket = io.connect(window.location.protocol + "//" + window.location.host + '/');
WebInspector.socket.on('message', onWebSocketMessage);
WebInspector.socket.on('error', function(error) { console.error(error); });
WebInspector.socket.on('connect', onWebSocketConnected);
Something went wrong with that request. Please try again.