use glob v5.0.3 to follow symlinks and return realpaths #586
Conversation
| var relativePath = relativeUnixPath.split('/').join(path.sep); | ||
| return path.join(rootFolder, relativePath); | ||
| result = result.map(function(unixPath) { | ||
| return unixPath.split('/').join(path.sep); |
There was a problem hiding this comment.
Are you sure the paths are returned as absolute, even though you specify rootFolder via options.cwd and not as options.root?
Related: 1c06f8a and isaacs/node-glob@f3105a3
There was a problem hiding this comment.
yes - i had to fix the code above to avoid prepending the rootfolder twice (which breaks inspector). i also had a little exchange with isaacs about the realpath returned paths being absolute now (and the match results not). isaacs/node-glob#184
|
Thank you for the pull request, sorry for taking so long to review it. Can you please rebase it on top of the current master and address my comment above? |
|
rebased and comment addressed. |
|
Landed via 5e368e8. I have improved the README text a bit, squashed the commits and added more details to the commit message. Thank you for the contribution! |
Upgrade "glob" to v5.x and use the new options "follow" and "realpath". This way the file paths returned to the UI are the same as those used by Node/V8 runtime, which allows users to set breakpoints in symlinked files. Close node-inspector#586 Fix node-inspector#370
Upgrade "glob" to v5.x and use the new options "follow" and "realpath". This way the file paths returned to the UI are the same as those used by Node/V8 runtime, which allows users to set breakpoints in symlinked files. Close node-inspector#586 Fix node-inspector#370
The glob module now has options to return realpaths and follow symlinks. With glob v5.0.3. this feature is usable with node-inspector.
Preloaded scripts in symlinked directories now show up properly in the inspector source tree and breakpoints work, fixing issue #370.
f.w.i.w. i also added a little debug tracing in ScriptFileStorage. e.g. to trace during tests do:
Fix #370