Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyboardEvent.key instead of KeyboardEvent.keyIdentifier in front-end #955

Merged
merged 1 commit into from Apr 9, 2017

Conversation

@sparkleholic
Copy link
Contributor

sparkleholic commented Dec 7, 2016

As KeyboardEvent.keyIdentifier is removed from the recent browsers
including chrome 54 rev, front-end should use KeyboardEvent.key instead.

(note.)
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyIdentifier

browser including chrome 54 rev,
front-end need to use KeyboardEvent.key instead.

(note.)
developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyIdentifier
@gabmontes
Copy link

gabmontes commented Feb 1, 2017

This PR should fix #903. Any news on test/merge/release? Thanks!!

abernix added a commit to meteor/docs that referenced this pull request Mar 9, 2017
Due to a bug in `node-inspector`, pushing "Enter" after a command on the Node Inspector Console will not successfully send the command to the server.

node-inspector/node-inspector#903

This helpful tip can be reverted if/when node-inspector/node-inspector#955 lands.
@codeHatcher
Copy link

codeHatcher commented Mar 10, 2017

Is it possible to merge this, it looks like the tests failed because of a timeout. There is a dependency on this package which has been causing issues for months over here meteor/meteor#8469

@ghost
Copy link

ghost commented Mar 16, 2017

I'm also excited for this to be merged, this fix saved me a LOT of time.

@hustxiaoc hustxiaoc merged commit 841ffc1 into node-inspector:master Apr 9, 2017
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.