KeyboardEvent.key instead of KeyboardEvent.keyIdentifier in front-end #955

Merged
merged 1 commit into from Apr 9, 2017

Conversation

Projects
None yet
4 participants
@sparkleholic
Contributor

sparkleholic commented Dec 7, 2016

As KeyboardEvent.keyIdentifier is removed from the recent browsers
including chrome 54 rev, front-end should use KeyboardEvent.key instead.

(note.)
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyIdentifier

As KeyboardEvent.keyIdentifier is removed from the recent
browser including chrome 54 rev,
front-end need to use KeyboardEvent.key instead.

(note.)
developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyIdentifier
@gabmontes

This comment has been minimized.

Show comment
Hide comment
@gabmontes

gabmontes Feb 1, 2017

This PR should fix #903. Any news on test/merge/release? Thanks!!

gabmontes commented Feb 1, 2017

This PR should fix #903. Any news on test/merge/release? Thanks!!

abernix added a commit to meteor/docs that referenced this pull request Mar 9, 2017

Add a warning about node-inspector console.
Due to a bug in `node-inspector`, pushing "Enter" after a command on the Node Inspector Console will not successfully send the command to the server.

node-inspector/node-inspector#903

This helpful tip can be reverted if/when node-inspector/node-inspector#955 lands.
@codeHatcher

This comment has been minimized.

Show comment
Hide comment
@codeHatcher

codeHatcher Mar 10, 2017

Is it possible to merge this, it looks like the tests failed because of a timeout. There is a dependency on this package which has been causing issues for months over here meteor/meteor#8469

Is it possible to merge this, it looks like the tests failed because of a timeout. There is a dependency on this package which has been causing issues for months over here meteor/meteor#8469

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Mar 16, 2017

I'm also excited for this to be merged, this fix saved me a LOT of time.

ghost commented Mar 16, 2017

I'm also excited for this to be merged, this fix saved me a LOT of time.

@hustxiaoc hustxiaoc merged commit 841ffc1 into node-inspector:master Apr 9, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@renovate-tests renovate-tests referenced this pull request in renovate-tests/discover-package-files Jul 7, 2017

Open

Update dependency node-inspector to v1 #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment