From eb260800f7530370a3d853889b6ed18f65e113a0 Mon Sep 17 00:00:00 2001 From: Jiacheng Date: Mon, 17 Nov 2025 06:55:45 +0000 Subject: [PATCH 1/3] fix: test --- test/zip/uncompress_stream.test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/zip/uncompress_stream.test.js b/test/zip/uncompress_stream.test.js index cb2272a..d3fc8bf 100644 --- a/test/zip/uncompress_stream.test.js +++ b/test/zip/uncompress_stream.test.js @@ -194,7 +194,7 @@ describe('test/zip/uncompress_stream.test.js', () => { assert(!err); const res = dircompare.compareSync(originalDir, destDir); assert(res.distinct === 0); - assert(res.equal === 5); + assert.equal(res.equal, 5, 'equal files count mismatch'); assert(res.totalFiles === 4); assert(res.totalDirs === 1); done(); From 9e2694eac80f37bb847c1bc40d03759fa88f0fdd Mon Sep 17 00:00:00 2001 From: Jiacheng Date: Mon, 17 Nov 2025 06:57:29 +0000 Subject: [PATCH 2/3] fix: test --- test/zip/uncompress_stream.test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/zip/uncompress_stream.test.js b/test/zip/uncompress_stream.test.js index d3fc8bf..6dc32bd 100644 --- a/test/zip/uncompress_stream.test.js +++ b/test/zip/uncompress_stream.test.js @@ -193,7 +193,7 @@ describe('test/zip/uncompress_stream.test.js', () => { pump(sourceStream, uncompressStream, err => { assert(!err); const res = dircompare.compareSync(originalDir, destDir); - assert(res.distinct === 0); + assert.equal(res.distinct, 0, 'distinct files count mismatch'); assert.equal(res.equal, 5, 'equal files count mismatch'); assert(res.totalFiles === 4); assert(res.totalDirs === 1); From 7c601482a331b698294e5565985452434a8e5245 Mon Sep 17 00:00:00 2001 From: Jiacheng Date: Mon, 17 Nov 2025 07:12:57 +0000 Subject: [PATCH 3/3] fix: testcase --- test/zip/uncompress_stream.test.js | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/test/zip/uncompress_stream.test.js b/test/zip/uncompress_stream.test.js index 6dc32bd..0e4053e 100644 --- a/test/zip/uncompress_stream.test.js +++ b/test/zip/uncompress_stream.test.js @@ -201,15 +201,16 @@ describe('test/zip/uncompress_stream.test.js', () => { }); uncompressStream.on('entry', (header, stream, next) => { - stream.on('end', next); - if (header.type === 'file') { - stream.pipe(fs.createWriteStream(path.join(destDir, header.name))); + pipelinePromise(stream, fs.createWriteStream(path.join(destDir, header.name))) + .then(next) + .catch(done); } else { // directory fs.mkdir(path.join(destDir, header.name), { recursive: true }, err => { if (err) return done(err); stream.resume(); }); + stream.on('end', next); } }); }); @@ -231,15 +232,16 @@ describe('test/zip/uncompress_stream.test.js', () => { }); uncompressStream.on('entry', (header, stream, next) => { - stream.on('end', next); - if (header.type === 'file') { - stream.pipe(fs.createWriteStream(path.join(destDir, header.name))); + pipelinePromise(stream, fs.createWriteStream(path.join(destDir, header.name))) + .then(next) + .catch(done); } else { // directory fs.mkdir(path.join(destDir, header.name), { recursive: true }, err => { if (err) return done(err); stream.resume(); }); + stream.on('end', next); } }); });