Skip to content

add ignore support #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fengmk2 merged 3 commits into from
Jun 26, 2015
Merged

add ignore support #16

fengmk2 merged 3 commits into from
Jun 26, 2015

Conversation

@shepherdwind
Copy link
Contributor

@shepherdwind shepherdwind commented Jun 25, 2015

Closes #15

popomore
popomore reviewed Jun 25, 2015
View reviewed changes
package.json Outdated
Copy link
Member

@popomore popomore Jun 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use ~

shepherdwind
shepherdwind reviewed Jun 25, 2015
View reviewed changes
package.json
Copy link
Contributor Author

@shepherdwind shepherdwind Jun 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@popomore change to ~ now.

@shepherdwind
Copy link
Contributor Author

shepherdwind commented Jun 25, 2015

Travis-ci fail at node 0.11, but That run ok at my compute.

The fail part is just the array order changed, Maybe we should just ignore 0.11 error, just run on 0.12.

@fengmk2
Copy link
Member

fengmk2 commented Jun 25, 2015

@shepherdwind remove 0.11 from travis ci

fengmk2
fengmk2 reviewed Jun 25, 2015
View reviewed changes
.travis.yml Outdated
Copy link
Member

@fengmk2 fengmk2 Jun 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iojs-2

@shepherdwind
Copy link
Contributor Author

shepherdwind commented Jun 26, 2015

@fengmk2 I have remove 0.11 and 0.12 travis runner. Only left 0.10 and iojs-2.

@popomore
Copy link
Member

popomore commented Jun 26, 2015

LGTM

@popomore
Copy link
Member

popomore commented Jun 26, 2015

change 0.11 to 0.12?

@fengmk2
Copy link
Member

fengmk2 commented Jun 26, 2015

+1

fengmk2 added a commit that referenced this pull request Jun 26, 2015
@fengmk2
Merge pull request #16 from shepherdwind/feature/ignore
9163909 
add ignore support
@fengmk2 fengmk2 merged commit 9163909 into node-modules:master Jun 26, 2015
@fengmk2
Copy link
Member

fengmk2 commented Jun 26, 2015

@shepherdwind 1.7.0

@fengmk2 fengmk2 self-assigned this Jun 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@fengmk2 fengmk2

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shepherdwind @fengmk2 @popomore