Permalink
Browse files

add jshint

  • Loading branch information...
1 parent b84a654 commit cda97717eb43799b7772ddcf0e5912396dde1fc2 @fengmk2 fengmk2 committed Mar 6, 2014
Showing with 112 additions and 41 deletions.
  1. +3 −0 .jshintignore
  2. +93 −36 .jshintrc
  3. +2 −0 .npmignore
  4. +4 −1 Makefile
  5. +3 −1 examples/request_cnodejs.js
  6. +3 −1 examples/search_github.js
  7. +1 −0 package.json
  8. +3 −2 test/urllib.test.js
View
@@ -0,0 +1,3 @@
+node_modules/
+coverage/
+.git/
View
@@ -1,38 +1,95 @@
{
- "predef": [
- "module",
- "require",
- "__dirname",
- "process",
- "console",
- "it",
- "describe",
- "before",
- "after",
- "should"
- ],
+ // JSHint Default Configuration File (as on JSHint website)
+ // See http://jshint.com/docs/ for more details
- "node" : true,
- "es5": true,
- "bitwise": true,
- "curly": true,
- "eqeqeq": true,
- "forin": false,
- "immed": true,
- "latedef": true,
- "newcap": true,
- "noarg": true,
- "noempty": true,
- "nonew": true,
- "plusplus": false,
- "undef": true,
- "strict": false,
- "trailing": false,
- "globalstrict": true,
- "nonstandard": true,
- "white": true,
- "indent": 2,
- "expr": true,
- "multistr": true,
- "onevar": false
-}
+ "maxerr" : 50, // {int} Maximum error before stopping
+
+ // Enforcing
+ "bitwise" : true, // true: Prohibit bitwise operators (&, |, ^, etc.)
+ "camelcase" : false, // true: Identifiers must be in camelCase
+ "curly" : true, // true: Require {} for every new block or scope
+ "eqeqeq" : true, // true: Require triple equals (===) for comparison
+ "forin" : false, // true: Require filtering for..in loops with obj.hasOwnProperty()
+ "immed" : false, // true: Require immediate invocations to be wrapped in parens e.g. `(function () { } ());`
+ "indent" : false, // {int} Number of spaces to use for indentation
+ "latedef" : false, // true: Require variables/functions to be defined before being used
+ "newcap" : false, // true: Require capitalization of all constructor functions e.g. `new F()`
+ "noarg" : true, // true: Prohibit use of `arguments.caller` and `arguments.callee`
+ "noempty" : true, // true: Prohibit use of empty blocks
+ "nonew" : false, // true: Prohibit use of constructors for side-effects (without assignment)
+ "plusplus" : false, // true: Prohibit use of `++` & `--`
+ "quotmark" : false, // Quotation mark consistency:
+ // false : do nothing (default)
+ // true : ensure whatever is used is consistent
+ // "single" : require single quotes
+ // "double" : require double quotes
+ "undef" : true, // true: Require all non-global variables to be declared (prevents global leaks)
+ "unused" : false, // true: Require all defined variables be used
+ "strict" : true, // true: Requires all functions run in ES5 Strict Mode
+ "trailing" : false, // true: Prohibit trailing whitespaces
+ "maxparams" : false, // {int} Max number of formal params allowed per function
+ "maxdepth" : false, // {int} Max depth of nested blocks (within functions)
+ "maxstatements" : false, // {int} Max number statements per function
+ "maxcomplexity" : false, // {int} Max cyclomatic complexity per function
+ "maxlen" : false, // {int} Max number of characters per line
+
+ // Relaxing
+ "asi" : false, // true: Tolerate Automatic Semicolon Insertion (no semicolons)
+ "boss" : true, // true: Tolerate assignments where comparisons would be expected
+ "debug" : false, // true: Allow debugger statements e.g. browser breakpoints.
+ "eqnull" : false, // true: Tolerate use of `== null`
+ "es5" : false, // true: Allow ES5 syntax (ex: getters and setters)
+ "esnext" : true, // true: Allow ES.next (ES6) syntax (ex: `const`)
+ "moz" : false, // true: Allow Mozilla specific syntax (extends and overrides esnext features)
+ // (ex: `for each`, multiple try/catch, function expression…)
+ "evil" : false, // true: Tolerate use of `eval` and `new Function()`
+ "expr" : true, // true: Tolerate `ExpressionStatement` as Programs
+ "funcscope" : false, // true: Tolerate defining variables inside control statements"
+ "globalstrict" : false, // true: Allow global "use strict" (also enables 'strict')
+ "iterator" : false, // true: Tolerate using the `__iterator__` property
+ "lastsemic" : false, // true: Tolerate omitting a semicolon for the last statement of a 1-line block
+ "laxbreak" : false, // true: Tolerate possibly unsafe line breakings
+ "laxcomma" : false, // true: Tolerate comma-first style coding
+ "loopfunc" : false, // true: Tolerate functions being defined in loops
+ "multistr" : true, // true: Tolerate multi-line strings
+ "proto" : false, // true: Tolerate using the `__proto__` property
+ "scripturl" : false, // true: Tolerate script-targeted URLs
+ "smarttabs" : false, // true: Tolerate mixed tabs/spaces when used for alignment
+ "shadow" : true, // true: Allows re-define variables later in code e.g. `var x=1; x=2;`
+ "sub" : false, // true: Tolerate using `[]` notation when it can still be expressed in dot notation
+ "supernew" : false, // true: Tolerate `new function () { ... };` and `new Object;`
+ "validthis" : false, // true: Tolerate using this in a non-constructor function
+
+ // Environments
+ "browser" : true, // Web Browser (window, document, etc)
+ "couch" : false, // CouchDB
+ "devel" : true, // Development/debugging (alert, confirm, etc)
+ "dojo" : false, // Dojo Toolkit
+ "jquery" : false, // jQuery
+ "mootools" : false, // MooTools
+ "node" : true, // Node.js
+ "nonstandard" : false, // Widely adopted globals (escape, unescape, etc)
+ "prototypejs" : false, // Prototype and Scriptaculous
+ "rhino" : false, // Rhino
+ "worker" : false, // Web Workers
+ "wsh" : false, // Windows Scripting Host
+ "yui" : false, // Yahoo User Interface
+ "noyield" : true, // allow generators without a yield
+
+ // Legacy
+ "nomen" : false, // true: Prohibit dangling `_` in variables
+ "onevar" : false, // true: Allow only one `var` statement per function
+ "passfail" : false, // true: Stop on first error
+ "white" : false, // true: Check against strict whitespace and indentation rules
+
+ // Custom Globals
+ "globals" : { // additional predefined global variables
+ // mocha
+ "describe": true,
+ "it": true,
+ "before": true,
+ "afterEach": true,
+ "beforeEach": true,
+ "after": true
+ }
+}
View
@@ -6,3 +6,5 @@ test/
Makefile
lib-cov/
coverage.html
+.jshintrc
+.jshintignore
View
@@ -6,6 +6,9 @@ MOCHA_OPTS =
install:
@npm install --registry=http://registry.cnpmjs.org --cache=${HOME}/.npm/.cache/cnpm
+jshint: install
+ @./node_modules/.bin/jshint .
+
test: install
@NODE_ENV=test ./node_modules/mocha/bin/mocha \
--reporter $(REPORTER) \
@@ -25,7 +28,7 @@ test-coveralls: test
@echo TRAVIS_JOB_ID $(TRAVIS_JOB_ID)
@-$(MAKE) test MOCHA_OPTS='--require blanket' REPORTER=mocha-lcov-reporter | ./node_modules/coveralls/bin/coveralls.js
-test-all: test test-cov
+test-all: jshint test test-cov
autod: install
@./node_modules/.bin/autod -w
@@ -4,6 +4,8 @@
* MIT Licensed
*/
+ "use strict";
+
/**
* Module dependencies.
*/
@@ -14,4 +16,4 @@ urllib.request('http://cnodejs.org/', { wd: 'nodejs' }, function (err, data, res
console.log(res.statusCode);
console.log(res.headers);
console.log(data.toString());
-});
+});
@@ -1,5 +1,7 @@
// curl https://api.github.com/legacy/user/search/location:china
+"use strict";
+
var urllib = require('../');
urllib.request('https://api.github.com/legacy/user/search/location:china', {dataType: 'json'},
@@ -28,4 +30,4 @@ function (err, data, res) {
// req.on('error', function(e) {
// console.error(e);
-// });
+// });
View
@@ -32,6 +32,7 @@
"blanket": "*",
"coveralls": "*",
"formstream": "0.0.8",
+ "jshint": "*",
"mocha": ">=0.14.1",
"mocha-lcov-reporter": "*",
"pedding": "0.0.3",
View
@@ -313,7 +313,8 @@ describe('urllib.test.js', function () {
data.sql.should.equal(params1.data.sql);
data.data.should.equal(params1.data.data);
done();
- }
+ };
+
urllib.request(host + '/post', params1, check);
var params2 = {
type: 'put',
@@ -515,7 +516,7 @@ describe('urllib.test.js', function () {
should.not.exist(err);
data.should.be.an.instanceof(Buffer);
if (res.statusCode !== 200) {
- console.log(res.statusCode, res.headers)
+ console.log(res.statusCode, res.headers);
}
res.should.have.header('connection', 'keep-alive');
done();

0 comments on commit cda9771

Please sign in to comment.