New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the "maxLength" route registration syntax #8

Open
amitguptagwl opened this Issue Oct 7, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@amitguptagwl
Member

amitguptagwl commented Oct 7, 2018

A route can be registered with the following syntax

- route: 
    uri: "/list/transactions/:creditCard(:credit-card:)"
    maxLength: 1024 * 1024
    to: CreditCardService
    after: [ authentication, monitoring ]
    then: compress

To improve readability, we want to change the framework to support following syntax

A route can be registered with the following syntax

- route: 
    uri: "/list/transactions/:creditCard(:credit-card:)"
    with:
        maxLength: 1024 * 1024
    to: CreditCardService
    after: [ authentication, monitoring ]
    then: compress

Check routesManager to find the relevant code. Please updates the tests accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment