Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add support for specifying port 80/443 in the scope #63

Merged
merged 2 commits into from May 11, 2012

Conversation

Projects
None yet
2 participants

mac- commented May 7, 2012

I was running into issues where specifying port 80 on the URL that I pass to nock() was not producing a match when passing that same URL to http.request(). I understand that this may be expected, but in order to make the module a little more robust I made a few changes to allow someone to use nock('yourdomain.com:80') or nock('yourdomain.com') and the module will essentially treat them equally.

All the tests still pass, and I added an additional test to account for the added functionality.

@pgte pgte merged commit ffbf308 into node-nock:master May 11, 2012

Owner

pgte commented May 11, 2012

Thanks for the contribution.
Published nock v0.12.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment