Pull fix for issue #42 #48

Closed
wants to merge 6 commits into
from

Projects

None yet

5 participants

@tomlanyon

Are you happy with this fix for #42, essentially copying the TCP data to another buffer.

I considered actually changing tcp.data to be a new buffer for each packet but wasn't sure it was worth it.

tomlanyon and others added some commits May 2, 2012
@tomlanyon tomlanyon Copy TCP data into it's own buffer on each packet. Should fix #42 in …
…node_pcap.
ebca3a3
@psanford @tomlanyon psanford Don't crash when encountering unknown tcp options.
There are two types of tcp options:
  - "A single octet of option-kind"
  - "An octet of option-kind, an octet of option-length, and
     the actual option-data octets."

Only option 0 and 1 are single the single octet type. So we safely
determine the length of unknown options and skip them.
1fddca7
@abkqz @tomlanyon abkqz Added byte counter which can be used for progress-tracking on huge dumps 872229a
@abkqz @tomlanyon abkqz Changes RST flag handling.
It can arrive when state machine is in any state, previous version failed for some dumps.
b89cace
@tomlanyon tomlanyon Added timestamp to each tcp packet
Conflicts:

	pcap.js
1b3d685
@tomlanyon tomlanyon add code to clean up huge session array every so often
Merged from github/throughnothing d2f4fe4

Conflicts:

	pcap.js
da0dc54
@ujjwalt
Collaborator
ujjwalt commented Nov 17, 2013

@tomlanyon Can you look into this if it's already fixed or not?

@jmaxxz
Collaborator
jmaxxz commented Mar 12, 2015

Cleaning up pull requests

Reopen with one based on current master if this is still an issue.

@jmaxxz jmaxxz closed this Mar 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment