Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback on 'Delete a message property' #29

Closed
rajbir123 opened this issue Jul 10, 2018 · 11 comments
Closed

Feedback on 'Delete a message property' #29

rajbir123 opened this issue Jul 10, 2018 · 11 comments

Comments

@rajbir123
Copy link

rajbir123 commented Jul 10, 2018

Small Feedback for documentation:
Your div block is too small and narrow and need to scroll everytime to check the contents.
Its too much annoying as content kept in small and narrow div, its make difficult for comparison with respect to other nodes.

Better remove this line which is no use ie max-height and the overflow-y:
div.flow pre {
/* max-height: 100px;
overflow-y: scroll; */
}

@knolleary
Copy link
Member

Thanks for the feedback; this was an intentional choice as flow json can get quite long and most times a user just wants to copy it, not read it. Flooding the page with json reduces the readability of a recipe.

@rajbir123
Copy link
Author

rajbir123 commented Jul 11, 2018

@knolleary thnks.
But thats not the correct way to handle in everywhere. If its relates to flow.json file then u can use that but it has been used everywhere which makes so much annoying as everytime to scroll and make some comparison between the nodes. Pls make it user reliable to read the documentation as easy as it is.

#one more question want to ask, Is there any other stuffs/materials apart from this documentation where I could understand the inside the code flow and the architecture of nodered I mean any videos materials etc apart from this documentation.

@knolleary
Copy link
Member

@rajbir123 can you link to some examples of non-flow code blocks that have had this style applied?

@rajbir123
Copy link
Author

rajbir123 commented Jul 11, 2018

@knolleary brother, I got your point that u made it for flow.json to handle the large data. You didnt get what I said just to remove that style if its possible, let it increase the length or height of content. Atleast user will see and understand it properly for visualization.

Ex: Seems like keeping 20 people inside one car and its difficult for the user to see and analyse each one of them.. :)

@knolleary
Copy link
Member

@rajbir123 sorry, I did misunderstand:

If its relates to flow.json file then u can use that but it has been used everywhere

I read that to mean you didn't mind it being used for flow file, but that is had been used 'everywhere'. So I was curious to know what you mean by everywhere other than flow files.

I do take your point - I'm sure there's a better answer that helps keep it readable without flooding the page.

@rajbir123
Copy link
Author

rajbir123 commented Aug 31, 2018

@knolleary thank you so much for your kind reply, I am your big fan :) actually I love Node Red flow based programming.
I have one more issue or doubt. It may be bug or feature that u have been added.
In node red dashboard palette, if i want to customize the name of node suppose HTTP-response but what I see by default dash (-) is replaced by space and it always give HTTP response. I want to make it HTTP-response in the palette, so please let me know where and what to change.

@knolleary
Copy link
Member

knolleary commented Aug 31, 2018

@rajbir123 When displaying node types in the palette, it automatically replaces - with spaces. That's just what it does - there's nothing you can do about it.

Please don't use this as a general thread for questions - the Node-RED Forum is available for that.

@rajbir123
Copy link
Author

@Sorry for asking you here, but please tell me how to make it with with - dash ie http-response in the palette

@knolleary
Copy link
Member

You can use the dash in the name, but when it is displayed it will get replaced with a space.

To repeat my response: That's just what it does - there's nothing you can do about it.

Can I ask why you want the existing HTTP Response node to be presented as http-response or are you just using that as an example?

@rajbir123
Copy link
Author

@knolleary thats just an example.. Nick, Actually I am trying to make my own custom node with such name with dash - so please tell me how to achieve this.

@knolleary
Copy link
Member

For the third time: there's nothing you can do about it in your node. That is just what the palette does when displaying node labels.

https://github.com/node-red/node-red/blob/69448c73290ca59ae8430ff6d64bfa41f77bfc4a/editor/js/ui/palette.js#L75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants