Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Node does not show state correctly #497

Closed
Harpau opened this issue May 16, 2019 · 13 comments

Comments

2 participants
@Harpau
Copy link

commented May 16, 2019

If I add the Dashboard link to the Homescreen of my iPhone and open the Dashboard by clicking the Icon created on the Homescreen then all charts are shown again with a legend.
If I open the Dashboard using a Bookmark in Safari it works well.
I have cleared the cache in the Safari Settings and I have created the Link on the Homescreen completely new, but it does not work reproducible.
With the previous Versions this didn’t occur.
Many thanks again for your continuing support.
Harald

@dceejay

This comment has been minimized.

Copy link
Member

commented May 16, 2019

Works fine here - again I suspect you have some sort of cacheing issue.

@dceejay dceejay closed this May 16, 2019

@Harpau

This comment has been minimized.

Copy link
Author

commented May 16, 2019

@dceejay

This comment has been minimized.

Copy link
Member

commented May 16, 2019

sorry - no I'm not an expert on iphone safari/home screen cacheing - google is probably a better bet.

@Harpau

This comment has been minimized.

Copy link
Author

commented May 16, 2019

@dceejay

This comment has been minimized.

Copy link
Member

commented May 16, 2019

indeed there was a bug in 2.15.0 that was fixed in 2.15.2. Using 2.15.2 on my iphone homescreen (having not tried 2.15.0 so nothing cached anywhere) I can see that the legend can be turned on and off from the server side and the client behaves as it should.

@Harpau

This comment has been minimized.

Copy link
Author

commented May 16, 2019

@Harpau

This comment has been minimized.

Copy link
Author

commented May 16, 2019

@Harpau

This comment has been minimized.

Copy link
Author

commented May 16, 2019

2019-05-16 (4)
2019-05-16 (5)
2019-05-16 (6)
2019-05-16 (7)

@dceejay

This comment has been minimized.

Copy link
Member

commented May 16, 2019

Not as far as I know. This new problem is nothing to do with cacheing of web page widgets / js / css files. I notice you have many nodes there that are not core nodes so I am unable to help with those or if they have any bearing on the situation.

If you wish to discuss another problem it maybe best to raise it on the public discourse forum as a much wider group watch there and can possibly help.

@Harpau

This comment has been minimized.

Copy link
Author

commented May 16, 2019

@dceejay

This comment has been minimized.

Copy link
Member

commented May 16, 2019

yes the broken version worked if you do that - it was the flag from the ui it was ignoring. Works if you override it. So yes that ia workaround for you, but others that haven't got a bad cache won't need it.

@Harpau

This comment has been minimized.

Copy link
Author

commented May 16, 2019

OK, regarding the Switch Node issue, I have tried it with a very simple test flow now:

[{"id":"7f81fb86.10e664","type":"inject","z":"91330dca.821c3","name":"","topic":"","payload":"true","payloadType":"bool","repeat":"","crontab":"","once":true,"onceDelay":"2","x":90,"y":200,"wires":[["d5576ece.10911","5dd9f6a2.86ad08"]]},{"id":"d5576ece.10911","type":"debug","z":"91330dca.821c3","name":"","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"false","x":330,"y":260,"wires":[]},{"id":"5dd9f6a2.86ad08","type":"ui_switch","z":"91330dca.821c3","name":"","label":"Test","tooltip":"","group":"1560620a.8febce","order":0,"width":0,"height":0,"passthru":false,"decouple":"true","topic":"","style":"","onvalue":"true","onvalueType":"bool","onicon":"","oncolor":"","offvalue":"false","offvalueType":"bool","officon":"","offcolor":"","x":310,"y":140,"wires":[[]]},{"id":"1560620a.8febce","type":"ui_group","z":"","name":"Test","tab":"ee5c0835.2b15d8","disp":true,"width":"6","collapse":false},{"id":"ee5c0835.2b15d8","type":"ui_tab","z":"","name":"Test","icon":"dashboard","disabled":false,"hidden":false}]

Now I open Node Red and leave the Dashboard closed. I press the Inject Button. The State of the Switch Node becomes "ON". I open the Dashboard and the Switch shows "OFF". I press again the Inject Button while leaving the Dashboard open and the Switch goes to "ON". If I close the Dashboard and open it again, the Switch shows again "OFF".

@dceejay

This comment has been minimized.

Copy link
Member

commented May 16, 2019

OK - so that is a proper bug - can you edit the title of this thread to reflect this issue.

@dceejay dceejay reopened this May 16, 2019

@Harpau Harpau changed the title Legend is shown even if Legend Option set to "None" when opening by a Homescreen Link on iPhone Switch Node does not show state correctly May 16, 2019

@dceejay dceejay added the bug label May 16, 2019

@dceejay dceejay closed this in 7ee2468 May 16, 2019

@dceejay dceejay added this to Work in Progress in Dashboard - Things to do May 21, 2019

@dceejay dceejay moved this from Work in Progress to Released to npm - 2.15.0, 1, 2, 3 in Dashboard - Things to do May 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.