Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sensortag - support for the TI Sensortag 2 #107

Closed
vielmetti opened this issue Mar 18, 2015 · 8 comments
Closed

sensortag - support for the TI Sensortag 2 #107

vielmetti opened this issue Mar 18, 2015 · 8 comments

Comments

@vielmetti
Copy link

TI has a new version of their Sensortag. This issue is tracking support for that new version in the underlying library:

sandeepmistry/node-sensortag#34

The current state of things (March 2015) is that there are patches available from TI that add some support for the Sensortag 2, and with those supplied patches installed the node-red-node-sensortag module does work (albeit without support yet for the new sensors) though support is not yet complete. The goal is to merge everything in together and that hasn't yet happened.

I don't know the best place to discuss this, but most of the details are on the above mentioned issue. There is a little bit of subtlety involved as the new device has a couple more sensors, and the driver code in node-sensortag tries to figure out what kind of device it's talking to. I think that can be all hidden from Node-RED.

@vielmetti
Copy link
Author

There's a pull request here (please don't merge it! but it seemed to be the best way to share the change, it's not ready yet).

#108

It adds support for the luxometer (light meter) reporting on sensorTag/lux.

@knolleary
Copy link
Member

Hi, thanks for this.

AS per our contribution guidelines, we need a signed CLA before we can accept pull-requests - https://github.com/node-red/node-red/blob/master/CONTRIBUTING.md#contributor-license-agreement

As a general comment, you can just post a link to your repo/branch/commit if you want us to look at something - the pull request isn't needed until the code is read to merge.

@vielmetti
Copy link
Author

Thanks, I'll get the CLA done. I wasn't quite sure of the best way to proceed to notify you all, I'll hold off on further pull requests until everything else is ready.

@dceejay
Copy link
Member

dceejay commented Jul 9, 2015

Closing this as have recently updated the sensorTag node to support the newer tag also...
(but still not multiple tags at once)

@dceejay dceejay closed this as completed Jul 9, 2015
@vielmetti
Copy link
Author

Thanks. I think that multiple tags (or multiple BLE devices in general) is a harder issue

@dceejay
Copy link
Member

dceejay commented Jul 9, 2015

yes - I think there is some progress in the library but it's not a done deal... so as this issue was about tag2 and that now works we'll leave this closed and can open a new issue for multiple tags... if required.

@vielmetti
Copy link
Author

There is an existing issue #109 that was closed, @dceejay - take a look at that and see if it's reopenable, or I can write up a new one that reflects the broader issue of managing multiple connections to multiple diverse BLE devices at the same time.

@vielmetti
Copy link
Author

As noted on #109, IBM has this problem addressed in an IBM-IoT contribution at. https://github.com/ibm-iot/node-red-contrib-sensortag . (just to bring this issue to a satisfying close)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants