Skip to content

Conversation

@sammachin
Copy link
Contributor

  • [x ] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Fixed the what3words node to convert from w3w address to lat/long, it now functions as per the help details.

Checklist

  • [x ] I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the mailing list/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@jsf-clabot
Copy link

jsf-clabot commented Feb 6, 2019

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 65.784% when pulling b30c029 on sammachin:master into 8178153 on node-red:master.

@coveralls
Copy link

coveralls commented Feb 6, 2019

Coverage Status

Coverage remained the same at 65.784% when pulling 2ce126d on sammachin:master into 8178153 on node-red:master.

@dceejay
Copy link
Member

dceejay commented Feb 6, 2019

Hi - looks good - can you sign/accept the CLA so we can merge it ?
(though looking at it the .oneword path also needs the same fix a few lines below.)

added fix to Oneword
@sammachin
Copy link
Contributor Author

I've added the fix to Oneword as well, CLA should be signed

@dceejay
Copy link
Member

dceejay commented Feb 11, 2019

Great - thanks

@dceejay dceejay merged commit ac2f9ad into node-red:master Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants