From faae0fee9f08ad4337092bb9cd1ad4c150aaf4b6 Mon Sep 17 00:00:00 2001
From: Andreas Lindemann <AndLindemann@users.noreply.github.com>
Date: Fri, 14 Jun 2024 17:17:38 +0200
Subject: [PATCH] Fix error messages on invalid directions API requests and add
 a "success" node status (#319)

* Google Directions: Add success status and correct error message on failure

* Update translation en-US

* Update german translations
---
 google/directions.js                 | 13 +++++--------
 google/locales/de/directions.json    |  3 ++-
 google/locales/en-US/directions.json |  3 ++-
 3 files changed, 9 insertions(+), 10 deletions(-)

diff --git a/google/directions.js b/google/directions.js
index fb732319..1638745b 100644
--- a/google/directions.js
+++ b/google/directions.js
@@ -156,6 +156,7 @@ module.exports = function(RED) {
                             lon: newMsg.payload.routes[0].legs[0].end_location.lon
                         }
                     };
+		    node.status({fill:"green",shape:"ring",text:"directions.status.success"});
                     cb(newMsg);
                 } else if (data.status == 'ZERO_RESULTS') {
                     newMsg = cloneMsg(msg);     //quick clone msg
@@ -187,21 +188,17 @@ module.exports = function(RED) {
                             break;
                         case 'REQUEST_DENIED':
                             error.code = 400;
-                            error.message = RED._("directions.error.request-denied");
+                 	    error.message = RED._("directions.error.request-denied");
                             break;
                         case 'UNKNOWN_ERROR':
-							error.code = 500;
+			    error.code = 500;
                             error.message = RED._("directions.error.unknown-error");
-							break;
+			    break;
                         default:
                             error.code = 500;
                             error.message = RED._("directions.error.unknown-error");
                     }
-                    throwNodeError({
-                        code: 400,
-                        message: RED._("directions.error.no-destination"),
-                        status: 'MISSING_VALUES'
-                    }, msg);
+                    throwNodeError(error, msg);
                     return;
                 }
             }
diff --git a/google/locales/de/directions.json b/google/locales/de/directions.json
index 6de70ff3..6b1401b5 100644
--- a/google/locales/de/directions.json
+++ b/google/locales/de/directions.json
@@ -28,7 +28,8 @@
             "name": "Name"
         },
         "status": {
-            "failed": "Fehlgeschlagen"
+            "failed": "Fehlgeschlagen",
+            "success": "Erfolgreich"
         },
         "error": {
             "no-origin": "Bitte Startpunkt angeben",
diff --git a/google/locales/en-US/directions.json b/google/locales/en-US/directions.json
index d4db15c7..ad1f70ac 100644
--- a/google/locales/en-US/directions.json
+++ b/google/locales/en-US/directions.json
@@ -28,7 +28,8 @@
             "name": "Name"
         },
         "status": {
-            "failed": "failed"
+            "failed": "failed",
+            "success": "success"
         },
         "error": {
             "no-origin": "Please supply an origin value",