let split node specify property to split on, and join auto join correctly #4386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and let join auto join the correct property or manually the specified one.
knolleary
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
or manually the specified one.
Proposed changes
This PR lets the split node specify the property that it will split on... it adds the specified property to the parts property as 'parts.property'. It defaults to payload so should be non-breaking. So far testing and extra tests all work OK.
The join node can then rejoin the specified property automatically. Or operate on the property configured - again defaults to msg.payload.
Checklist
npm run testto verify the unit tests pass