Fix change node to return boolean if asked #4525
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to fix #4372
Proposed changes
As per Issue #4372 if asked to replace something with a boolean - currently if the search criteria is a regex then it returns as a string - (if the search is just a string then it returns a boolean correctly). This fix forces the replacement to be a boolean if requested.
As it is a slight change in behaviour I have left it on the 4.0 dev branch - but I think as it already half works then this is more of a bug fix tbh.
Checklist
npm run testto verify the unit tests pass