Refactor workspace grid to use single pattern definition#5735
Merged
Conversation
Contributor
Author
|
This was developed on Chrome (Blink) but before merge, we should test on Safari (Webkit) & Firefox (Gecko) |
Member
Contributor
Author
|
@knolleary 2nd last idea applied in 0edd9560edd956 (I have one more after this) |
Member
|
@Steve-Mcl much better across the 3 browsers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Types of changes
closes #5728
Proposed changes
Replace the individual dom line elements with a single rect that uses a pattern def
Before and after
Stats:
Comparison
nr--orig-grid-left--new-grid-right.mp4
DOM
Checklist
npm run testto verify the unit tests pass