Fix error handling for linkcall in function node#5755
Merged
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Types of changes
TLDR
If the call to
node.linkcall()errored / timed out, it could not be caught in the function node code & would ALWAYS perform anode.erroreven when wrapped in a try catchProposed changes
Remove try/catch handling so that user-defined function code can catch errors thrown by
node.linkcallusing a try/catch block, and that such handled errors do not trigger the catch node when they are handled by user code.Testing enhancements:
10-function_spec.jsthat ensures errors fromnode.linkcallcan be caught within user function code, and confirms that the catch node is not triggered when the error is handled by the user.Checklist
npm run testto verify the unit tests pass